[gnutls-devel] GnuTLS | ktls: basic implementation of SW mode (!1451)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1451 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_704937405

> +#else //ENABLE_KTLS
> +
> +int _gnutls_ktls_enable(gnutls_session_t session){

Shouldn't this be `gnutls_ktls_enable` or should the other be `_gnutls_ktls_enable`?

--
  
Daiki Ueno started a new discussion on lib/includes/gnutls/socket.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_704937407

>  
> +
> +

Leftover?

--
  
Daiki Ueno started a new discussion on lib/gnutls_int.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_704937409

>  	void *epoch_lock;
>  
> +	/* indicates weather or not was KTLS initialized properly. */

typo: weather → whether

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_704937410

> +				// ignore post-handshake messages
> +				if (type != record_type) {
> +					return _gnutls_ktls_recv_int(session,

Wouldn't simply return `GNUTLS_E_AGAIN` work?

--
  
Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451#note_704937414

> +		}
> +		break;
> +		default:

Although the other algorithms are already filtered out, it might make sense to add `assert(0)` here to catch any future programming error.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1451
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211015/ff335469/attachment.html>