[gnutls-devel] GnuTLS | fips: plumb service indicator to public key algorithms (d66b7132)

[Read-only notification of GnuTLS library development activities]

Pedro Monreal started a new discussion on lib/fips.c: https://gitlab.com/gnutls/gnutls/-/commit/d66b713242ed5577f978e3c86c989142a817caa4#note_735619857

> +
> +void
> +_gnutls_fips_set_operation_state(gnutls_fips140_operation_state_t state)
> +{
> +#ifdef ENABLE_FIPS140
> +	if (!_tfips_context) {
> +		_gnutls_debug_log("FIPS140-2 context is not set\n");
> +		return;
> +	}
> +
> +	switch (_tfips_context->state) {
> +	case GNUTLS_FIPS140_OPERATION_STATE_INITIAL:
> +		_tfips_context->state = state;
> +		_gnutls_debug_log("FIPS140-2 operation mode switched from %s to %s\n",
> +				  operation_state_to_string(_tfips_context->state),
> +				  operation_state_to_string(state));

The debug message would print the same string values. Consider this:

```
		_gnutls_debug_log("FIPS140-2 operation mode switched from %s to %s\n",
				  operation_state_to_string(GNUTLS_FIPS140_OPERATION_STATE_INITIAL),
				  operation_state_to_string(state));
```
Check also the other cases.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/commit/d66b713242ed5577f978e3c86c989142a817caa4#note_735619857
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211117/52b1970b/attachment-0001.html>