[gnutls-devel] GnuTLS | locks: couple of improvements using Gnulib glthread (!1485)

[Read-only notification of GnuTLS library development activities]

Daiki Ueno commented on a discussion on lib/kx.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1485#note_733505661

>  #pragma GCC diagnostic push
>  #pragma GCC diagnostic ignored "-Wanalyzer-file-leak"
>  
> +GNUTLS_ONCE(keylog_once);
> +
> +static void
> +keylog_once_init(void)
> +{
> +	const char *keylogfile;
> +
> +	keylogfile = secure_getenv("SSLKEYLOGFILE");
> +	if (keylogfile != NULL && *keylogfile != '\0') {

I think it's a classic idiom to allow users to invalidate the effect of envvar with `SSLKEYLOGFILE= command`. It also aligns with the NSS [behavior](https://hg.mozilla.org/projects/nss/file/77b0c937dfaac74495cd2b498370b0e2668562bb/lib/ssl/sslsock.c#l3919).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1485#note_733505661
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211115/49e2a877/attachment-0001.html>