[gnutls-devel] GnuTLS | locks: couple of improvements using Gnulib glthread (!1485)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Nov 15 11:52:32 CET 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1485 was reviewed by Alexander Sosedkin

Alexander Sosedkin started a new discussion on lib/kx.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1485#note_733147890

> +
> +	keylogfile = secure_getenv("SSLKEYLOGFILE");
> +	if (keylogfile != NULL && *keylogfile != '\0') {

Mild: Why the new non-empty-string check? My vote's for warning.

Alexander Sosedkin started a new discussion on lib/tpm2_esys.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1485#note_733147897

> +
> +static void
> +tcti_once_init(void)

Do I understand correctly that a library reinitialization (e.g., with `gnutls_global_set_mutex`) will deinit `tcti_ctx` and never reinit it again?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1485
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211115/0639cf0e/attachment.html>

More information about the Gnutls-devel mailing list