[gnutls-devel] GnuTLS | priority: rework config reloading logic and locking (!1483)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Nov 1 19:12:58 CET 2021




Alexander Sosedkin started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1483#note_720233469

>   **/
>  const char *gnutls_get_system_config_file(void)
>  {
> -	if (system_wide_priority_strings_init)
> +	if (system_wide_priority_strings)

What's the purpose of this check and returning `NULL`? `system_priority_file` is set early and guarded by `global_init_mutex`, so, without locking, this makes it a "filename of the system wide configuration loaded or currently being loaded by the library; NULL if loading hasn't been attempted yet". Lock and turn into "filename of loaded; NULL if not yet"? Stop returning NULL?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1483#note_720233469
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211101/7115fd8e/attachment.html>


More information about the Gnutls-devel mailing list