[gnutls-devel] GnuTLS | fips: avoid memleak in (EC)DH internal APIs (!1380)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Jan 22 14:45:05 CET 2021

Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1380

Project:Branches: dueno/gnutls:wip/dueno/fips-dh-memleak to gnutls/gnutls:master
Author:    Daiki Ueno

There were some confusions of gnutls_pk_params_clear and
gnutls_pk_params_release, as well as the number of parameters to scan
in the gnutls_pk_params_st structure.

Flagged by address sanitizer:
  ==354688==ERROR: LeakSanitizer: detected memory leaks

  Direct leak of 192 byte(s) in 12 object(s) allocated from:
      #0 0x7f13506163cf in __interceptor_malloc (/lib64/libasan.so.6+0xab3cf)
      #1 0x7f13503b94de in wrap_nettle_mpi_init /home/ueno/devel/gnutls/lib/nettle/mpi.c:79
      #2 0x7ffcb8495f07  ([stack]+0x1ef07)

  Direct leak of 160 byte(s) in 10 object(s) allocated from:
      #0 0x7f13506163cf in __interceptor_malloc (/lib64/libasan.so.6+0xab3cf)
      #1 0x7f13503b94de in wrap_nettle_mpi_init /home/ueno/devel/gnutls/lib/nettle/mpi.c:79

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1380
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210122/2b884320/attachment-0001.html>

More information about the Gnutls-devel mailing list