[gnutls-devel] GnuTLS | Verify that cert_list_size > 0 and cert_list != NULL (!1379)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Jan 11 08:14:50 CET 2021

Tom Carroll created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1379

Project:Branches: incentive.design/gnutls:check_cert_list_argument to gnutls/gnutls:master
Author:    Tom Carroll

cert_list_size (similarly, ca_list_size) are signed integers that specify the length of cert_list (ca_list). As the size variable is used for compute a memory allocation, there is an implicit assumption that it is greater than zero. This patch makes the assumption explicit by checking that cert_list_size > 0. Additionally, cert_list cannot be NULL as cert_list_size > 0.

## Checklist
 * [X] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [X] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1379
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210111/295f41fe/attachment.html>

More information about the Gnutls-devel mailing list