[gnutls-devel] GnuTLS | gnutls_certificate_set_x509_key(): deinitialize pcerts array elements during cleanup (!1378)

[Read-only notification of GnuTLS library development activities]

Tom Carroll created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1378

Project:Branches: incentive.design/gnutls:pcert_deinit_on_cleanup to gnutls/gnutls:master
Author:    Tom Carroll



The cleanup path of gnutls_certificate_set_x509_key() does not deinitialize the elements of the pcert array. The gnutls_pcert_st has two fields, pubkey and cert, that should be freed or else a memory leak will occur.


## Checklist
 * [X] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [X] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1378
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210111/f23681e6/attachment.html>