[gnutls-devel] GnuTLS | Draft: priority: partial fix for gnutls_protocol_set_enabled enabling (!1501)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Tue Dec 21 13:53:58 CET 2021

Alexander Sosedkin created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1501

Project:Branches: asosedkin/gnutls:protocol-set-fixing to gnutls/gnutls:master
Author:   Alexander Sosedkin

Reviewer: Daiki Ueno

This is a straightforward hack to fix the most of `gnutls_protocol_set_enabled` misbehaving scenarios from #1307. I made it lock global config and recalculate the effective priority string. Can't say this is clean in any way, so consider carefully. Also, looking into that made me scared of config reload interplay.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1501
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211221/327e0f18/attachment.html>

More information about the Gnutls-devel mailing list