[gnutls-devel] GnuTLS | ktls: API (!1477)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Dec 15 11:16:29 CET 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1477 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on lib/system/ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1477#note_776871316

> +gnutls_transport_is_ktls_enabled(gnutls_session_t session){
> +	if (unlikely(!session->internals.initial_negotiation_completed))
> +		return gnutls_assert_val(GNUTLS_E_UNAVAILABLE_DURING_HANDSHAKE);

I think here is a type mismatch with the return type. Maybe just return 0 (logging with `_gnutls_debug_log` might be helpful).

Daiki Ueno started a new discussion on tests/gnutls_ktls.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1477#note_776871338

>  #define MAX_BUF 1024
> -#define MSG "Hello world!"
> +#define MSG "Hello world!\0"

I don't think this change is needed; a NUL character is automatically appended at the end of string literals (see 6 at [the spec](http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1570.pdf#page=89)).

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1477
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211215/8e477db1/attachment.html>

More information about the Gnutls-devel mailing list