[gnutls-devel] GnuTLS | test for gnutls_protocol_set_enabled, TCP (!1494)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Dec 8 15:42:47 CET 2021

Alexander Sosedkin created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1494

Project:Branches: asosedkin/gnutls:test-allowlisting-proto-tcp to gnutls/gnutls:master
Author:   Alexander Sosedkin

I wrote a test for gnutls_protocol_set_enabled where the shell part of it feeds commands into a small C interpreter. Feels overengineered to me, but I can't figure out how to slim it down reasonably either. Only TCP is tested so far.

A portion of the scenarios currently fail, they're commented out in the current version.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1494
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211208/b9598441/attachment.html>

More information about the Gnutls-devel mailing list