[gnutls-devel] GnuTLS | Avoid tests killing entire process groups (!1463)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Sat Aug 28 08:02:24 CEST 2021

Daiki Ueno commented on a discussion on tests/tls13/prf-early.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1463#note_663317229

>  {
>  	int status = 0;
> -	kill(child, SIGTERM);
> -	wait(&status);
> +	if (child) {

Given `kill(0, SIGTERM)` is an unexpected condition, I think it's worthwhile to mark it explicitly as a programming error, with `assert(child)`. On the other hand, if we allow the use of `terminate` even in child process, we probably don't need to replace the `terminate` calls with `exit`.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1463#note_663317229
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210828/694fb34e/attachment.html>

More information about the Gnutls-devel mailing list