[gnutls-devel] GnuTLS | WIP: Add Linux kernel AF_ALG backend (!1404)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Apr 1 17:59:09 CEST 2021

Stephan Mueller started a new discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_543271078

>  		return gnutls_assert_val(GNUTLS_E_INVALID_REQUEST);
>  	memcpy(ctx->iv, iv, iv_size);
> +	if(!ctx->encdec){

Sorry for the nit (and I guess you have tested it), but the afalg_cipher_init parameter is called enc - I would interpret that it contains 1 for encryption and 0 for decryption. If my interpretation would be correct, isn't this here a reversion of the logic?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1404#note_543271078
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210401/8ea126df/attachment-0001.html>

More information about the Gnutls-devel mailing list