[gnutls-devel] GnuTLS | Fix optional arguments handling in gnutls_privkey_import_rsa_raw() (!1318)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Sep 2 19:04:36 CEST 2020

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1318 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on tests/key-import-export.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1318#note_406204723

> +	/* Optional arguments */
> +	ret = gnutls_privkey_import_rsa_raw(key, &_rsa_m, &_rsa_e, &_rsa_d, &_rsa_p, &_rsa_q, NULL, NULL, NULL);

Can't those permutations rewritten as a loop?

Daiki Ueno started a new discussion on lib/nettle/pk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1318#note_406204726

> +		/* marks RSA_COEF as present */
> +		params->params_nr = RSA_PRIVATE_PARAMS - 2;

It might be a little easier to read if this is moved right before `calc_rsa_exp`?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1318
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200902/4d45d0c4/attachment.html>

More information about the Gnutls-devel mailing list