[gnutls-devel] GnuTLS | pubkey: avoid spurious audit messages from _gnutls_pubkey_compatible_with_sig() (!1301)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Thu Jul 23 06:42:18 CEST 2020

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1301 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on lib/pubkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1301#note_384202821

> +			return gnutls_assert_val(ret);
> +	}
> +

nit: it might be a little simpler to consolidate two `if`s?


	se = _gnutls_sign_to_entry(sign);
	if (se != NULL) {
		ret = pubkey_supports_sig(pubkey, se);
		if (ret < 0)
			return gnutls_assert_val(ret);
	} else if (_gnutls_version_has_selectable_sighash(ver)) {
		return gnutls_assert_val(GNUTLS_E_INVALID_REQUEST);

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1301
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200723/8cbcadb8/attachment-0001.html>

More information about the Gnutls-devel mailing list