[gnutls-devel] GnuTLS | New CI runner with clang combined ubsan+asan (!1151)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1151 was reviewed by Nikos Mavrogiannopoulos

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/hello_ext.c: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_275963750

>  
> -	msg &= GNUTLS_EXT_FLAG_SET_ONLY_FLAGS_MASK;
> +	msg &= (gnutls_ext_flags_t) GNUTLS_EXT_FLAG_SET_ONLY_FLAGS_MASK;

I think that looks quite strange. Maybe we change msg to unsigned int instead?

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/hello_ext.c: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_275963753

>  
> -	msg &= GNUTLS_EXT_FLAG_SET_ONLY_FLAGS_MASK;
> +	msg &= (gnutls_ext_flags_t) GNUTLS_EXT_FLAG_SET_ONLY_FLAGS_MASK;

same here about changing msg to unsigned.

--
  
Nikos Mavrogiannopoulos started a new discussion on lib/record.c: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_275963755

>   */
> +#ifdef __clang__
> +// "implicit-signed-integer-truncation:record.c" in UBSAN suppression file doesn't work.

Not sure what we are suppressing here. Would you like to add more info about it in the comment?

--
  
Nikos Mavrogiannopoulos started a new discussion on .gitlab-ci.yml: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_275963758

> +  - export CXX=clang++
> +
> +# This makes several tests fail, needs discussion if helpful

Is there something to discuss in this MR or should we remove the text?

--
  
Nikos Mavrogiannopoulos started a new discussion on .gitlab-ci.yml: https://gitlab.com/gnutls/gnutls/merge_requests/1151#note_275963762

> +  - export CXXFLAGS="$CFLAGS"
> +
> +# --disable-tls13-interop because tests/suite/testcompat-tls13-openssl.sh fails with clang sanitizers 

Is it due to our code? If yes, should we open an issue with what remains?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1151
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200123/eec8a860/attachment.html>