[gnutls-devel] GnuTLS | WIP: validate_name_constraints_node: eliminate known SAN check (!1167)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Mon Jan 13 16:30:52 CET 2020
Nikos Mavrogiannopoulos created a merge request: https://gitlab.com/gnutls/gnutls/merge_requests/1167
Project:Branches: nmav/gnutls:tmp-san-fix to gnutls/gnutls:master
Author: Nikos Mavrogiannopoulos
The known SAN check was incorrect as it was hard-coding the supported at the time SANs, and it was not necessary as the previous code would only return a supported SAN and the follow-up code did not depend unknown SANs.
## Checklist
* [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [x] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1167
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200113/3e8d695f/attachment.html>
More information about the Gnutls-devel
mailing list