[gnutls-devel] GnuTLS | libgnutls: Add system-wide default-priority-string override. (!1158)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/merge_requests/1158#note_270526277

>  		if (ret < 0)
>  			return 0;
>  	} else if (c_strcasecmp(section, OVERRIDES_SECTION)==0) {
> -		if (c_strcasecmp(name, "insecure-hash")==0) {
> +		if (c_strcasecmp(name, "default-priority-string")==0) {
> +			_clear_default_system_priority();
> +			p = clear_spaces(value, str);
> +			_gnutls_debug_log("cfg: setting default-priority-string to %s\n", p);
> +			if (strlen(p) > 0) {
> +				_gnutls_default_priority_string = gnutls_strdup(p);
> +				if (!_gnutls_default_priority_string) {
> +					_gnutls_default_priority_string = DEFAULT_PRIORITY_STRING;
> +					_gnutls_debug_log("cfg: failed setting default-priority-string %d\n",

Sorry I missed that. What's the purpose of printing errno here? What about just memory error? I'm thinking that we don't use the errno on any other memory allocation failures and using it only here will not be providing much value.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1158#note_270526277
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200113/0501e1fd/attachment.html>