[gnutls-devel] GnuTLS | UB+ASAN: Fail tests if UB detected (!1136)

[Development of GNU's TLS library]

Tim Rühsen commented on a discussion on .gitlab-ci.yml: https://gitlab.com/gnutls/gnutls/merge_requests/1136#note_266394106

> +  - dash ./configure --cache-file cache/config.cache --disable-guile --disable-doc --disable-hardware-acceleration
> +  - sed -i 's/-Werror/-Wno-parentheses -Werror/g' src/Makefile
>    - make -j$(nproc)
> -  - make check -j$(nproc)
> -  - CFLAGS="-std=c99 -fsanitize=undefined -fsanitize=bool -fsanitize=alignment -fsanitize=null -fsanitize=bounds-strict -fsanitize=enum -fno-sanitize-recover -g -O2" CXXFLAGS=$CFLAGS LDFLAGS="-static-libubsan" dash ./configure
> -   --cache-file cache/config.cache --disable-non-suiteb-curves --disable-guile --disable-doc --disable-full-test-suite --with-default-trust-store-pkcs11="pkcs11:"
> +  - sed -i 's/-Werror//g' fuzz/Makefile tests/Makefile tests/slow/Makefile
> +  - make check -j$(nproc) -C fuzz
> +  - make check -j$(nproc) -C tests
> +  - dash ./configure --cache-file cache/config.cache --disable-guile --disable-doc --disable-hardware-acceleration --with-default-trust-store-pkcs11="pkcs11:"
>    - make clean
> +  - sed -i 's/-Werror/-Wno-parentheses -Werror/g' src/Makefile
>    - make -j$(nproc)
> -  - make -C tests check -j$(nproc) TESTS="trust-store p11-kit-load.sh" SUBDIRS=.
> +  - sed -i 's/-Werror//g' fuzz/Makefile tests/Makefile tests/slow/Makefile
> +  - make check -j$(nproc) -C fuzz

Sure ? If you are right, then we have to improve fuzzing :-) IMO, that test doesn't really hurt and we don't have to think about it once we improve the fuzzers. Do we need another issue for that ?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1136#note_266394106
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200102/73964be6/attachment.html>