[gnutls-devel] GnuTLS | gnutls_session_set_secret_function: rename from gnutls_handshake_* (!1193)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Mon Feb 17 17:32:28 CET 2020

Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1193

Branches: tmp-rename-secret-hook to master
Author:    Daiki Ueno

This is a follow-up of !1184. Although the API was merged, on second thought I found the naming of the function/callback (prefixed with `gnutls_handshake_`) are confusing, because those can be used even after handshake is completed. This is to rename them with the `gnutls_session_` prefix.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [x] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [x] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1193
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200217/6088f1aa/attachment.html>

More information about the Gnutls-devel mailing list