[gnutls-devel] GnuTLS | Mangle/hide GNUTLS-built ecc_scalar_random() (!1300)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Thu Aug 13 12:07:37 CEST 2020




Daiki Ueno started a new discussion on devel/import-ecc-from-nettle.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/1300#note_395423261

>  	;;
>        */ecc-random.c )
>  	sed \
> -	  -e 's/"nettle-internal\.h"/"nettle-alloca.h"/' \
> +	  -e 's/"nettle-internal\.h"/"nettle-alloca.h"\nvoid ecc_scalar_random(struct ecc_scalar \*, void \*, nettle_random_func \*);/' \

Using a backslash escape (`\n`) in replacement is not portable, for example:
```console
ueno at gcc-solaris10:~$ echo a > a
ueno at gcc-solaris10:~$ sed 's/a/"bar"\n"foo"/' a
"bar"n"foo"
```
I'd suggest using `i` and `d` combination as in:
https://gitlab.com/gnutls/gnutls/-/blob/master/devel/import-from-nettle.sh#L134

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1300#note_395423261
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200813/00f531ab/attachment.html>


More information about the Gnutls-devel mailing list