[gnutls-devel] GnuTLS | _gnutls_fips_mode_enabled: treat selftest failure as FIPS disabled (!1306)

[Development of GNU's TLS library]

Sahana Prasad started a new discussion on lib/fips.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1306#note_394629816

>  #ifdef ENABLE_FIPS140
>  	unsigned ret = _gnutls_fips_mode_enabled();
>  
> -	if (ret > GNUTLS_FIPS140_DISABLED)
> +	if (ret > GNUTLS_FIPS140_DISABLED) {
> +		/* If the previous run of selftests has failed, return as if
> +		 * the FIPS mode is disabled. We could use HAVE_LIB_ERROR, if

could we also add something like "caller must check the macro HAVE_LIB_ERROR() after the operation" updated in the function description?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1306#note_394629816
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200812/176c7f5e/attachment-0001.html>