[gnutls-devel] GnuTLS | gnutls_base64_decode2() succeeds decoding the empty string (!1124)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Thu Nov 28 15:09:44 CET 2019

Nikos Mavrogiannopoulos created a merge request: https://gitlab.com/gnutls/gnutls/merge_requests/1124

Project:Branches: nmav/gnutls:tmp-fix-base64 to gnutls/gnutls:master
Author:    Nikos Mavrogiannopoulos

This is a behavioral change of the API but it conforms to the RFC4648 expectations.

While that's a "correct" change in the terms of RFC compliance, it may break existing applications that may rely on that broken behavior of the API. Seeing [codesearch at debian](https://codesearch.debian.net/search?q=gnutls_base64_decode2&literal=1&perpkg=1), that API doesn't seem to be popular so any breakage should be limited.

Resolves: #834

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [x] Code modified for feature
 * [x] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [x] Documentation updated / NEWS entry present (for non-trivial changes)
 * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1124
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20191128/7f8bed88/attachment-0001.html>

More information about the Gnutls-devel mailing list