[gnutls-devel] GnuTLS | WIP: gnutls_hkdf{expand, extract}: new API functions exposed (!1115)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1115 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/crypto-api.c: https://gitlab.com/gnutls/gnutls/merge_requests/1115#note_240029689

> +
> +		hmac_sha256_set_key(&ctx, SHA256_DIGEST_SIZE, secret);
> +		return hkdf_expand(&ctx, (nettle_hash_update_func*)hmac_sha256_update,

Note that `hkdf_expand` doesn't return any error.

--
  
Daiki Ueno started a new discussion on lib/crypto-api.c: https://gitlab.com/gnutls/gnutls/merge_requests/1115#note_240029691

> +		gnutls_assert();
> +	}
> +}

I see "\ No newline at end of file"; depending on the editor you use, but afaik vim and emacs add a newline automatically.

--
  
Daiki Ueno started a new discussion on lib/crypto-api.c: https://gitlab.com/gnutls/gnutls/merge_requests/1115#note_240029693

> +	}
> +	default:
> +		gnutls_assert();

Shouldn't we return an error here?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1115
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20191105/48e78b43/attachment-0001.html>