[gnutls-devel] GnuTLS | Datum.c cleanup (!1002)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri May 24 16:43:31 CEST 2019

Nikos Mavrogiannopoulos started a new discussion on lib/srp.c: https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_174267315

>  				     unsigned int salt_length)
>  {
>  	_gnutls_free_datum(&cred->fake_salt_seed);
> -	_gnutls_set_datum(&cred->fake_salt_seed, seed->data, seed->size);
> +	if (_gnutls_set_datum(&cred->fake_salt_seed, seed->data, seed->size) < 0) {

Hmmm, with that change here, doesn't it mean that on failure there is no error indication an the fake_salt_seed is now uninitialized?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_174267315
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190524/6107f0e6/attachment.html>

More information about the Gnutls-devel mailing list