[gnutls-devel] GnuTLS | _gnutls_srp_entry_free: follow consistent behavior in freeing data (!995)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri May 10 09:40:03 CEST 2019




Tim Rühsen started a new discussion on lib/auth/srp_passwd.c: https://gitlab.com/gnutls/gnutls/merge_requests/995#note_168596894

>  	_gnutls_free_datum(&entry->salt);
>  
>  	if ((entry->g.data != gnutls_srp_1024_group_generator.data)
> -	    && (entry->g.data != gnutls_srp_3072_group_generator.data))

LGTM. There is just this inconsistency in breaking lines. Here you use `&& (expr)` and below `expr &&`.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/995#note_168596894
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190510/02ef9ea0/attachment.html>


More information about the Gnutls-devel mailing list