[gnutls-devel] GnuTLS | gnutls_session_get_desc: avoid printing a NULL value (!1038)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1038 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/session.c: https://gitlab.com/gnutls/gnutls/merge_requests/1038#note_186669149

>  					 group_name, sign_str);
> -			else
> +			else if (group_name)

This check looks redundant to the outer `if`.

--
  
Daiki Ueno started a new discussion on tests/openconnect-dtls12.c: https://gitlab.com/gnutls/gnutls/merge_requests/1038#note_186669150

> +		fail("client: gnutls_session_get_desc: NULL\n");
> +
> +	if (strstr(desc, "null") != NULL)

Wouldn't it make sense to check against the actual string returned from `gnutls_session_get_desc`?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1038
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190629/4c57b613/attachment-0001.html>