[gnutls-devel] GnuTLS | nettle/rnd-fips: add FIPS 140-2 continuous RNG test (!1034)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1034 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_186559964

>  #include <rnd-common.h>
>  
> +#define ENTROPY_BLOCK_SIZE SHA256_DIGEST_SIZE

It's actually chosen arbitrarily, but I've added a comment.

--
  
Daiki Ueno commented on a discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_186559971

>  /* Reseed a generator. */
> -static int drbg_reseed(struct drbg_aes_ctx *ctx)
> +static int drbg_reseed(struct drbg_aes_ctx *ctx,

Indeed, passing the fips context makes the code simpler.

--
  
Daiki Ueno commented on a discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_186559974

>  }
>  
> +static int get_entropy(struct fips_ctx *fctx, uint8_t *buffer, size_t length)

OK, so I will keep it thread-local.  Thank you for the confirmation.

--
  
Daiki Ueno commented on a discussion on lib/nettle/rnd-fips.c: https://gitlab.com/gnutls/gnutls/merge_requests/1034#note_186559977

>  #define PSTRING_SIZE (sizeof(PSTRING)-1)
> -static int drbg_init(struct drbg_aes_ctx *ctx)
> +static int drbg_init(struct drbg_aes_ctx *ctx,

Done.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1034
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190628/ed93abe9/attachment.html>