[gnutls-devel] GnuTLS | gnutls | lib: add support for AES-GMAC (!1036)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos commented:


Looks good to me. What I noticed while reviewing this, is that we don't really test `gnutls_hmac_fast` with anything than MD5,SHA1 (in `tests/gnutls_hmac_fast.c`), and we may miss a bug introduced there. Would it make sense to test it together with everything else in `test_mac()` of self-tests, or should we add a individual tests in `tests/gnutls_hmac_fast.c`?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1036#note_186026582
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190627/dc4a9971/attachment.html>