[gnutls-devel] GnuTLS | fips: run selftests over overriden AES-CBC algorithm (!1027)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Wed Jun 12 14:22:40 CEST 2019
New Merge Request !1027
https://gitlab.com/gnutls/gnutls/merge_requests/1027
Branches: tmp-aes-cbc-selftest to master
Author: Daiki Ueno
Assignees:
Previously, we only tested nettle's AES-CBC in `_gnutls_fips_perform_self_checks1()`, which is called before the implementation is overriden. This adds an AES-CBC self-test in `_gnutls_fips_perform_self_checks2()` so it can test the actual implementation.
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1027
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190612/f683ca77/attachment-0001.html>
More information about the Gnutls-devel
mailing list