[gnutls-devel] GnuTLS | set_ciphersuite_list(): Use linear approach to cleanup priorities (!889)

[Development of GNU's TLS library]

Tim Rühsen commented on a discussion on lib/priority.c:

>  	 * a pre-TLS1.2 protocol is there; that is because servers which
>  	 * do not support TLS1.3 will negotiate TLS1.2 if seen a TLS1.3 handshake */
>  	if (unlikely((!have_psk && tlsmax && tlsmax->id >= GNUTLS_TLS1_3 && priority_cache->groups.size == 0)) ||
> -	    (!have_tls12 && have_pre_tls12 && have_tls13)) {
> -		for (i = 0; i < priority_cache->protocol.num_priorities; i++) {
> +	    (!have_tls12 && have_pre_tls12 && have_tls13))
> +	{

Having the brace at the end of a continuation line is harder to read when you quickly read source code. This is just my personal observation/experience after so many years of reading code. Rules are for breaking them ;-)

But in this case I don't mind (it isn't my project). I'll amend it.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/889#note_134251478
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190123/1949ba7a/attachment-0001.html>