[gnutls-devel] GnuTLS | When sending no extensions do not include a zero length (!868)

[Development of GNU's TLS library]

New Merge Request !868

https://gitlab.com/gnutls/gnutls/merge_requests/868

Branches: tmp-fix-regression-ext-size to master
Author:    Nikos Mavrogiannopoulos
Assignee:  
Approvers: Simon Josefsson, Dmitry Eremin-Solenikov, Hubert Kario, Tim Rühsen, Andreas Metzler, Daiki Ueno, Tom, Ander Juaristi, Tomáš Mráz, Anderson Sasaki and GnuTLS devel mailing list


When sending no extensions do not include a zero length
    
According to RFC5246:
```
       The presence of extensions can be detected by determining whether
       there are bytes following the compression_method field at the end of
       the ServerHello.
``` 
and as such we correct our behavior to not send the zero length bytes. This was our behavior in 3.5.x and 3.3.x branch, and thus this corrects a regression of gnutls with these branches.

## Checklist
 * [x] Code modified for feature
 * [x] Test suite updated with negative tests
 * [x] Documentation updated / NEWS entry present (for non-trivial changes)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/868
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190108/47ecc9b3/attachment-0001.html>