[gnutls-devel] GnuTLS | Re-introduce topendir on Windows with Unicode support (!932)

[Development of GNU's TLS library]

Hugo Beauzée-Luyssen commented on a discussion on lib/x509/verify-high2.c:

>  		while (d != NULL);
>  		closedir(dirp);
>  	}
> +#else /* _WIN32 */
>  
> +	_TDIR *dirp;
> +	struct _tdirent *d;
> +	gnutls_datum_t utf16 = {NULL, 0};
> +
> +	r = _gnutls_utf8_to_ucs2(dirname, strlen(dirname), &utf16);
> +	if (r < 0)
> +		return gnutls_assert_val(r);
> +	dirp = _topendir((_TCHAR*)utf16.data);
> +	gnutls_free(utf16.data);
> +	if (dirp != NULL) {
> +		do {

Hm, actually I don't think we can assume that closedir(NULL) is safe, so the `d != NULL` check must stay

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/932#note_143640899
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190221/88b5bd7b/attachment-0001.html>