[gnutls-devel] GnuTLS | Fix issues in record_size_limit extension handling (!879)

[Development of GNU's TLS library]

Daiki Ueno commented on a discussion on lib/ext/record_size_limit.c:

>  	if (new_size < MIN_RECORD_SIZE)
>  		return 0;
>  
> -	session->internals.hsk_flags |= HSK_RECORD_SIZE_LIMIT_NEGOTIATED;
> +	/* if a record size larger than user specified maximum, ignore it */
> +	if (new_size > session->security_parameters.max_record_send_size)
> +		return 0;
>  
> -	/* if a larger record size limit than the protocol limit is
> -	 * provided by the peer, ignore it and stick to the default */
> -	if (unlikely(new_size > DEFAULT_MAX_RECORD_SIZE))
> -		return gnutls_assert_val(0);

Yes, in https://gitlab.com/gnutls/gnutls/merge_requests/879/diffs?commit_id=39058a8f3318fc9de4cc56f0ec900e223eea3725#eed9c09cadb2e1fc877ebb77b9165ec9f0c432ce_76_81 it is actually clamped to `max_record_send_size`, whose default is `DEFAULT_MAX_RECORD_SIZE`.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/879#note_139607101
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190208/55bed9ef/attachment.html>