[gnutls-devel] GnuTLS | x509: reject certificates having duplicate extensions (!1145)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Sun Dec 29 22:54:23 CET 2019
Nikos Mavrogiannopoulos created a merge request: https://gitlab.com/gnutls/gnutls/merge_requests/1145
Project:Branches: nmav/gnutls:tmp-check-dup-extensions to gnutls/gnutls:master
Author: Nikos Mavrogiannopoulos
According to RFC5280 a certificate must not include more than one instance of a particular extension. We were previously printing warnings when such extensions were found, but that is insufficient to flag such certificates. Instead, refuse to import them.
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [x] Code modified for feature
* [x] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [x] Documentation updated / NEWS entry present (for non-trivial changes)
* [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1145
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20191229/d72d5f50/attachment-0001.html>
More information about the Gnutls-devel
mailing list