[gnutls-devel] GnuTLS | Do not tolerate invalid DER time (!1141)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Mon Dec 23 21:10:51 CET 2019

Nikos Mavrogiannopoulos created a merge request: https://gitlab.com/gnutls/gnutls/merge_requests/1141

Project:Branches: nmav/gnutls:tmp-strict-x509-time to gnutls/gnutls:master
Author:    Nikos Mavrogiannopoulos

This effectively reverts !400 and ensures that we no longer tolerate invalid DER time. This complements the previous commit by Lili Quan and ensures we provide the --disable-strict-der-time backwards compatibility option.

In practice this change together with Lili Quan's patch are a behavioral change of gnutls' DER parser (stricter checks), but with the option to disable at compile time, I believe we provide a good compromise between allowing broken certificates for longer than necessary.
Resolves: #207

## Checklist
 * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1141
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20191223/24a9b410/attachment.html>

More information about the Gnutls-devel mailing list