[gnutls-devel] GnuTLS | Use locale-independant string comparisons and character type checks (#570)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri Sep 21 15:24:21 CEST 2018

New Issue was created.

Issue 570: https://gitlab.com/gnutls/gnutls/issues/570
Author:    Tim Rühsen

Just saw that the code is full of calls to strcasecmp/strncasecmp and is... (isdigit, ...) where definitely a pure ASCII comparison is wanted. Those functions have side known effects in certain locales (e.g. turkish 'I' / 'i' do not transform into each other while they do in other locales).

There might be a few places where those functions are explicitly needed, but normally the ASCII variants are the proper choice. Gnulib gives us those functions already (e.g. c_strcasecmp, c_isdigit, ...), so it's mainly a search&replace job spiced with #includes and addition of the appropriate gnulib modules to `bootstrap.conf`.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/issues/570
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180921/b4aa7d38/attachment.html>

More information about the Gnutls-devel mailing list