[gnutls-devel] GnuTLS | WIP: RFC7250 Raw public keys (!650)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri Sep 14 13:26:54 CEST 2018


Nikos Mavrogiannopoulos started a new discussion on lib/pcert.c:

>  	switch (type) {
> -	case GNUTLS_CRT_X509:
> -		return gnutls_pcert_import_x509_raw(pcert,
> -						    &info->
> -						    raw_certificate_list
> -						    [0],
> -						    GNUTLS_X509_FMT_DER,
> -						    GNUTLS_PCERT_NO_CERT);
> -	default:
> -		gnutls_assert();
> -		return GNUTLS_E_INTERNAL_ERROR;
> +		case GNUTLS_CRT_X509:
> +			return gnutls_pcert_import_x509_raw(pcert,
> +							&info->raw_certificate_list[0],
> +							GNUTLS_X509_FMT_DER,
> +							GNUTLS_PCERT_NO_CERT); // REMARK: this last param is not used.

That was probably some kind of optimization which was later removed. We can remove it completely for simplicity (though it has to remain in the exported header as a no-op).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/650#note_101412070
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180914/01948611/attachment.html>


More information about the Gnutls-devel mailing list