[gnutls-devel] GnuTLS | RFC7250 Raw public keys (!650)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos started a new discussion on lib/pcert.c:

> +{
> +	/* For convenience we reuse the internal pcert structure to hold
> +	 * our raw public key. By doing so we only need one certificate
> +	 * structure that can hold multiple certificate-like credential
> +	 * types.
> +	 */
> +	int ret;
> +
> +	if (pubkey == NULL) {
> +		return gnutls_assert_val(GNUTLS_E_INVALID_REQUEST);
> +	}
> +
> +	memset(pcert, 0, sizeof(*pcert));
> +
> +	/* A pcert struct holds a raw copy of the certificate data.
> +	 * Therefore we convert our gnutls_pubkey_t to its raw DER

Not sure if we need both the comments above and this one. I am not sure what is the value of this text here as comment vs adding all information we need to document in the function documentation.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/650#note_120389564
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181127/b370ff62/attachment.html>