[gnutls-devel] GnuTLS | tpm: Try to use password from the PIN callback if srk_password is NULL (!796)

[Development of GNU's TLS library]

Stefan Berger commented on a discussion on lib/tpm.c:

>  
>  	if (attempts > 0)
>  		flags |= GNUTLS_PIN_WRONG;
> +	else

It probably should now be `attempts > 1`, if that's what you mean. The behavior without this patch is that `tpm_pin()` gets called after trying with the well-known SRK password first and if it fails calling `tpm_pin()` once, trying the TPM operationg, and then the flag is set when calling `tpm_pin()` again. We could also call tpm_pin() with a `0` the first time and count attempts after.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/796#note_119780045
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181124/313537aa/attachment.html>