[gnutls-devel] GnuTLS | certtool: don't output textual information if --no-text was given (!810)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos started a new discussion on tests/cert-tests/pkcs7:

>  fi
>  done
>  
> +${VALGRIND} "${CERTTOOL}" --inder --p7-info --infile "${srcdir}/data/full.p7b" --outfile "${TMPFILE}" --no-text
> +rc=$?
> +
> +if test "${rc}" != "0"; then
> +	echo "--no-text pkcs7 info failed 1"
> +	exit ${rc}
> +fi
> +
> +if ( head -n 1 ${TMPFILE} ; tail -n 1 ${TMPFILE} ) | grep -v -- -----

What is the intention here? Also the if with empty body seems quite strange. Why not use not, or the format above with checking $? for return code?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/810#note_119750050
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181124/b88c91a4/attachment-0001.html>