[gnutls-devel] GnuTLS | record: make CCS handling stricter in TLS 1.3 (!817)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri Nov 23 14:54:14 CET 2018


Daiki Ueno commented on a discussion on lib/record.c:

>  	_mbuffer_head_remove_bytes(&session->internals.record_recv_buffer,
>  				   record.header_size + record.length);
>  
> +	/* protected CCS is not allowed in TLS 1.3 */

Yes, actually the check in `record_add_to_buffers` is:
```c
case GNUTLS_CHANGE_CIPHER_SPEC:
	if (!(IS_DTLS(session))) {
		ret = gnutls_assert_val(GNUTLS_E_UNEXPECTED_PACKET);
		goto cleanup;
	}
```
so protected CCS are already rejected.  I removed the check in `_gnutls_recv_in_buffers`.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/817#note_119638437
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181123/4cbc5edf/attachment.html>


More information about the Gnutls-devel mailing list