[gnutls-devel] GnuTLS | Add CI tarball build (!809)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos started a new discussion on tests/slow/cipher-api-test.c:

>  			if (ret < 0)
>  				fail("could not add auth data\n");
>  
> -			signal(SIGABRT, custom_abrt);
> -			ret = gnutls_cipher_add_auth(ch, data, 16);
> -			signal(SIGABRT, SIG_DFL);
> -			if (ret >= 0 && error_detected == 0)
> -				fail("succeeded in adding auth data data after partial data were given\n");
> +			if (testmode == 1) {
> +				/* either fails or calls abort() via assert(): */

Hmmm, what is not tested here is whether abort was actually called. Maybe a portable way would be to use the same method as used in `tls13/prf.c`, ie., override the abort() call, using something that sets `error_detected=1`. That way we will not rely on the signal at all. I guess if `tls13/prf.c` works on alpine, that would work too.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/809#note_119175820
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181121/c4e78e05/attachment-0001.html>