[gnutls-devel] [PATCH] Re: TCP Fast Open

[Nikos Mavrogiannopoulos]

On Sat, 2016-07-16 at 21:04 +0200, Tim Rühsen wrote:

> I forked gnutls to https://gitlab.com/rockdaboot/gnutls. What do I
> have to do that the CI works on the fork ?

If you give me admin rights on the repository (user nmav) I'll enable
them for you.

> No promise to make it - I already had a look at it. I don't see a way
> to 
> simplify code paths. It looks like _gnutls_writev_emu() is needed
> anyways, and 
> there is the need for checking the type of callback (fd or session).
> Moving 
> the code around (e.g. checks into system_writev() doesn't really help
> either).
> So maybe my first impression was simply wrong. Without (all) the
> push 
> callbacks taking session instead of fd, we can't simplify it. Even if
> that 
> looks like a (weak) design flaw in the past, we can't change it
> easily without 
> breaking existing application code. I guess we have to live with that
> ugly 
> code in the patch. Maybe you see more and/or have a good idea about
> it.

Ok, if that's the case, let's land it as a merge request, and we see
how it can be handled.

regards,
Nikos