[PATCH v2 1/2] Add support for DTLS-SRTP profile negotiation (RFC 5764)

[Nikos Mavrogiannopoulos]

On 11/01/2012 12:34 AM, Martin Storsjo wrote:

> ---
> Implemented what was suggested before, and moved some hunks that I
> accidentally had placed in patch 2/2 in the previous patchset.
> ---
>  NEWS                            |    6 +
>  doc/Makefile.am                 |   10 +
>  doc/protocol/rfc5764.txt        | 1459 +++++++++++++++++++++++++++++++++++++++
>  lib/ext/Makefile.am             |    2 +-
>  lib/ext/srtp.c                  |  465 +++++++++++++
>  lib/ext/srtp.h                  |   38 +
>  lib/gnutls_extensions.c         |    5 +
>  lib/gnutls_int.h                |    1 +
>  lib/includes/gnutls/gnutls.h.in |   30 +
>  lib/libgnutls.map               |    5 +
>  10 files changed, 2020 insertions(+), 1 deletion(-)
>  create mode 100644 doc/protocol/rfc5764.txt
>  create mode 100644 lib/ext/srtp.c
>  create mode 100644 lib/ext/srtp.h

Hello Martin,
 I've applied it. Thank you. I've done the following changes:
* gnutls_srtp_set_profile_direct returns GNUTLS_E_INVALID_REQUEST on
parsing error
* changed the copyright to you until the formal paperwork is finished
(so we can roll a release with it).

I've also added a test program in tests/mini-dtls-srtp.c. Could you help
there with the correct extractor parameters so that this is also checked?

Is the key size fixed for each profile? If yes, then wouldn't be easier
to have a helper function to extract the key, based on the negotiated
profile?

regards,
Nikos