make distcheck failure in gnutls-guile 'ERROR: no code for module (gnutls)'

[Simon Josefsson]

ludo at gnu.org (Ludovic Courtès) writes:

> Hi Simon,
>
> Simon Josefsson <simon at josefsson.org> skribis:
>
>> ludo at gnu.org (Ludovic Courtès) writes:
>
> [...]
>
>>> Ooh, here ERR is #f, instead of being an error value.  That’s presumably
>>> because gnutls_handshake returned an error value that the GnuTLS
>>> bindings don’t know about (see comment in ‘guile/src/errors.c’.)
>>>
>>> Commit 1c59226bb239aa563d02b6ea8ed285de006e3b31 updates the list of
>>> error codes known to the Guile bindings, which solves the problem.
>>>
>>> The proper solution would be to automatically extract the list of error
>>> codes from gnutls.h.in, but I felt too busy today.  :-)
>>
>> Thank you!  We can look at automating this later on.
>
> OTOH, error codes are part of the API, so one could argue that doing it
> manual forces one to know what’s going on.

Will the guile self-checks fail for any new error code, or does it only
fail if the new error code is actually returned when running the rest of
the guile self checks?  I think we have added error codes befor without
noticing this.

/Simon