[sr #107539] Patch: crl.c: pointer targets differ in signedness

[Simon Josefsson]

Follow-up Comment #1, sr #107539 (project gnutls):

Re this code:

+  if (crl == NULL)
+    {
+      gnutls_assert ();
+      /* Need a GNUTLS_E_INVALID_PARAMETER */
+      return GNUTLS_E_SHORT_MEMORY_BUFFER;
+    }

The error typically used is GNUTLS_E_INVALID_REQUEST.

+      opaque *out = NULL;

What's the reason for this?  It is initialized later on.

+  if (buf == NULL || sizeof_buf == NULL)
+    {
+      gnutls_assert ();
+      return GNUTLS_E_INVALID_REQUEST;
+    }

This is quite wrong: read the documentation for the function, buf can be
NULL.  The same applies to a couple of more instance, and I stopped reading.

Some of the stuff is good, so please rework the patch and I'll review again.

/Simon


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/support/?107539>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/