[PATCH] Replace explicit version checks with feature checks

Jonathan Bastien-Filiatrault joe at x2a.org
Sat Aug 22 20:31:33 CEST 2009

Simon Josefsson wrote:
> Jonathan Bastien-Filiatrault <joe at x2a.org> writes:
>> Simon Josefsson wrote:
>>> Jonathan Bastien-Filiatrault <joe at x2a.org> writes:
>>>> Simon Josefsson wrote:
>>> How do I create a patch between your branch and master, to review it?  I
>>> haven't worked with multiple repositories, but willing to learn.
>>> /Simon
>> Alright, here is what you need to do:
>>  - Use a somewhat-pristine git repository cloned from savannah or whatever.
>>  - Add a remote: git remote add -f jonathan git://x2a.org/gnutls.git ;
>> this adds an entry in the .git/config file and fetches refs and objects
>> from my repository.
>>  - Create a local branch tracking my remote repository: git branch
>> --track buffers-redux jonathan/buffers-redux
>>  - Now you can git checkout buffers-redux to switch to that branch or do
>> a git diff master..buffers-redux . If you had not created a local branch
>> you could instead do git diff master..jonathan/buffers-redux
> Excellent, thank you!
> Quick comments:
> * Please add a comment describing what dump_bytes does, and preferrably
>   make it use _gnutls_bin2hex for hex encoding.  Is there a fixed-size
>   limit of 128 in the function?  If so, it would be nice to fix that.

I was not aware of the existence of the _gnutls_bin2hex function. The
fixed buffers in dump_bytes are emptied at the end of each line and
their maximum size is bounded by the number of bytes per line (16), so
it could in theory print  256^sizeof(size_t) bytes. I will fix
gnutls_buffers.c to use _gnutls_bin2hex.

> * What does the 'bufel' variable name refers to?  It looks non-english
>   to me, so I'd prefer using 'buf'.

A mbuffer is a chain of buffer elements. I use buf to refer to the whole
chain of buffers (mbuffer_head_st) and bufel to refer to a buffer
element (mbuffer_st). I don't mind changing the variable names if they
really bother you.

> * Some comments at the top of gnutls_mbuffers.? what it does would be
>   good.

Sure, I can do that. I was planning on adding those comments later on

> More later.

I'll be waiting.
> /Simon

Thanks !

More information about the Gnutls-devel mailing list