[gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again)

[Timo Schulz]

Ludovic Courtès wrote:

> The patch below (against) `HEAD' fixes OpenPGP keyring import.  It
> should also work for ASCII-armored keyrings, although I did not test it
> since I did not have ASCII-armored keyrings at hand.  It also adds a

I thought the problem would be fixed with the new opencdk code. I
might mix up things so, so please could you explain again what the
problem here is?


>   1. For some reason, `check_id ()' doesn't work with the second ID
>      that's commented in `keyring.c', although it should.  Actually, I

I will try to check this ASAP.


>         at 0x401D4B0: malloc (vg_replace_malloc.c:149)
>         by 0x420C7F3: (within /usr/lib/libgcrypt.so.11.2.2)
>         by 0x420CA60: gcry_malloc (in /usr/lib/libgcrypt.so.11.2.2)
>         by 0x420CCDC: gcry_calloc (in /usr/lib/libgcrypt.so.11.2.2)
>         by 0x402BBA5: cdk_calloc (main.c:163)
>         by 0x402E33A: cdk_kbnode_new (kbnode.c:41)
>         by 0x4030758: cdk_keydb_get_keyblock (keydb.c:1715)
>         by 0x4031953: cdk_keydb_search (keydb.c:938)
>         by 0x40325D7: cdk_keydb_get_pk (keydb.c:1268)
>         by 0x4029878: gnutls_openpgp_keyring_check_id (extras.c:103)
>         by 0x8048921: doit (keyring.c:163)
>         by 0x8048B44: main (utils.c:148)

Actually I already documented it in the TODO file, but the fix
is a little tricky because it is not obvious where the leak occurs.