[gnutls-dev] Guile related 'make install' failure

[Simon Josefsson]

After making the last release, I tried 'make install', but it failed:

Making install in guile
make[1]: Entering directory `/home/jas/src/gnutls/guile'
Making install in modules
make[2]: Entering directory `/home/jas/src/gnutls/guile/modules'
make[3]: Entering directory `/home/jas/src/gnutls/guile/modules'
make[3]: Nothing to be done for `install-exec-am'.
test -z "/usr/share/guile/site" || /bin/mkdir -p "/usr/share/guile/site"
 /bin/sh /home/jas/src/gnutls/build-aux/install-sh -c -m 644 'gnutls.scm' '/usr/share/guile/site/gnutls.scm'
cp: cannot create regular file `/usr/share/guile/site/_inst.15741_': Permission denied
 /bin/sh /home/jas/src/gnutls/build-aux/install-sh -c -m 644 'gnutls/extra.scm' '/usr/share/guile/site/gnutls/extra.scm'
mkdir: cannot create directory `/usr/share/guile/site/gnutls': Permission denied
mkdir: cannot create directory `/usr/share/guile/site/gnutls': Permission denied
make[3]: *** [install-nobase_dist_guilemoduleDATA] Error 1
make[3]: Leaving directory `/home/jas/src/gnutls/guile/modules'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/jas/src/gnutls/guile/modules'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/jas/src/gnutls/guile'
make: *** [install-recursive] Error 1
jas at mocca:~/src/gnutls$

This doesn't look right to me, 'make install' should never write outside
of $prefix by default; packages that do that is rather annoying at sites
with read-only /usr trees that use AFS or similar.  I'm testing the
patch below.  Ludovic, does it looks right to you?

/Simon

diff --git a/Makefile.am b/Makefile.am
index 14601ab..a55659d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -20,7 +20,7 @@
 # along with this file; if not, write to the Free Software Foundation,
 # Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
-DISTCHECK_CONFIGURE_FLAGS = --enable-gtk-doc --with-guile-site-dir
+DISTCHECK_CONFIGURE_FLAGS = --enable-gtk-doc
 
 SUBDIRS = lgl gl includes lib libextra src
 
diff --git a/configure.in b/configure.in
index 2b392f2..a8d9c74 100644
--- a/configure.in
+++ b/configure.in
@@ -139,15 +139,15 @@ if test "x$opt_guile_bindings" = "xyes"; then
       if test $is_guile_1_8 -eq 0; then
         AC_MSG_RESULT([yes])
 	case "x$with_guile_site_dir" in 
-	     x|xno)
+	     xno)
 		# Use the default $(GUILE_SITE).
 		GUILE_SITE_DIR
 		;;
-	     xyes)
+	     x|xyes)
 		# Automatically derive $(GUILE_SITE) from $(pkgdatadir).  This
 		# hack is used to allow `distcheck' to work (see
 		# `DISTCHECK_CONFIGURE_FLAGS' in the top-level `Makefile.am').
-		GUILE_SITE="${datadir}/guile/site"
+		GUILE_SITE="@datadir@/guile/site"
 		AC_SUBST(GUILE_SITE)
 		;;
 	     *)